Opened 13 years ago
Closed 13 years ago
#1593 closed defect (fixed)
[PATCH][HANG] webif periodicly will not respond
Reported by: | coolacid | Owned by: | alno |
---|---|---|---|
Priority: | minor | Component: | Webinterface |
Severity: | low | Keywords: | |
Cc: | Sensitive: | no |
Description
Revision
<Please fill in>
Issue Description
The webif_read function does not have a time out. So, if the connection for some reason dies, the thread will get stuck reading from the client web browser.
From my research, there doesn't appear to be an easy way to resolve this. Suggestions included a timer and signal handler.
When the issue occurs
Random
How the issue is reproducable
N/A - Leave a web console up for long periods of time.
Thread BT:
#0 0x00007f6f45606b8d in read () at ../sysdeps/unix/syscall-template.S:82
#1 0x00000000004153dc in webif_read (
buf=0x7f6f45c30070 "GET /image?i=ICHID HTTP/1.1\r\nHost: localhost:8888\r\nUser-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101206 Ubuntu/10.10 (maverick) Firefox/3.6.13\r\nAccept: image/png,image/*;q"..., num=1024, f=0x1d9cb00) at /srv/oscam-svn/oscam-svn/oscam-http-helpers.c:407
#2 0x00000000004241a1 in process_request (f=0x1d9cb00, in=...) at /srv/oscam-svn/oscam-svn/oscam-http.c:3000
#3 0x000000000042532b in http_srv () at /srv/oscam-svn/oscam-svn/oscam-http.c:3336
#4 0x00007f6f455ff971 in start_thread (arg=<value optimized out>) at pthread_create.c:304
#5 0x00007f6f4514e92d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#6 0x0000000000000000 in ?? ()
Attachments (1)
Change History (4)
by , 13 years ago
Attachment: | oscam-http.c-patch-1593-v1 added |
---|
comment:1 by , 13 years ago
I lied - it is easy to fix (I think). Submitted patch that may resolve the issue. Not fully tested - nor tested on windows.
comment:2 by , 13 years ago
Summary: | [HANG] webif periodicly will not respond → [PATCH][HANG] webif periodicly will not respond |
---|
I guess I can't edit to add REV - REV originally 4598 - patched/running against 4650.
comment:3 by , 13 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Thanks for the patch. Applied with #4708.
Patch file v1