command 'exit' broken in monitor module

[walter123]

All Versions of 1.2

Issue Description

command 'exit' broken in monitor module

When the issue occurs

everytime

How the issue is reproducable

login to monitor
enter 'commands' in monitor
enter 'keepalive'
enter 'exit' (now you should disconnected but it is not)
enter 'keepalive' again and you will see new output

[avs1978]

For me it is unclear, which monitor tool you use. Do you use the shell script or mpcsmon?

[walter123]

Replying to avs1978:

For me it is unclear, which monitor tool you use. Do you use the shell script or mpcsmon?

It doesn't matter which client you use. Try it with any monitor tool or on linux with "nc -u ip port". The behaviour should always the same. I personally use webmon.

[gf]

Ooops I have totally misread what the problem is :) You want to get disconnected, not to shutdown oscam (which is the shutdown command).

[gf]

This might do the job.

[gf]

Fixed in r7541.

[walter123]

In oscam 1.1 I will get in log that the client has disconnected
(oscam,c ->"cs_log("%s disconnected %s", username(client), buf);"

So I assume this ist not the correct behaviour, because the disconnect will not be logged.

[gf]

Why are you reopening the ticket? The exit command is working, right?

Logging the disconnect event is useless and totally unrelated to the reported issue?

[walter123]

Replying to gf:

Why are you reopening the ticket? The exit command is working, right?

Logging the disconnect event is useless and totally unrelated to the reported issue?

I agree the exit command is working.
I thought, I should mentioned the original behaviour like in 1.1

If this is not correct, we can close this ticket.

Sorry for the trouble.

[gf]

I think there is no need to log the disconnect events.