Opened 12 years ago

Closed 11 years ago

#2426 closed defect (fixed)

command 'exit' broken in monitor module

Reported by: walter123 Owned by: walter
Priority: minor Component: Monitor-Interface
Severity: medium Keywords: monitor module command
Cc: hondansx@…, Hondansx@… Sensitive: no

Description

All Versions of 1.2

Issue Description

command 'exit' broken in monitor module

When the issue occurs

everytime

How the issue is reproducable

login to monitor
enter 'commands' in monitor
enter 'keepalive'
enter 'exit' (now you should disconnected but it is not)
enter 'keepalive' again and you will see new output

Attachments (1)

test.diff (556 bytes ) - added by gf 12 years ago.
This might do the job.

Download all attachments as: .zip

Change History (10)

comment:1 by avs1978, 12 years ago

Priority: criticalminor

For me it is unclear, which monitor tool you use. Do you use the shell script or mpcsmon?

in reply to:  1 comment:2 by walter123, 12 years ago

Replying to avs1978:

For me it is unclear, which monitor tool you use. Do you use the shell script or mpcsmon?

It doesn't matter which client you use. Try it with any monitor tool or on linux with "nc -u ip port". The behaviour should always the same. I personally use webmon.

comment:3 by gf, 12 years ago

Ooops I have totally misread what the problem is :) You want to get disconnected, not to shutdown oscam (which is the shutdown command).

by gf, 12 years ago

Attachment: test.diff added

This might do the job.

comment:4 by gf, 12 years ago

Resolution: fixed
Status: newclosed

Fixed in r7541.

comment:5 by walter123, 11 years ago

Cc: Hondansx@… added

In oscam 1.1 I will get in log that the client has disconnected
(oscam,c ->"cs_log("%s disconnected %s", username(client), buf);"

So I assume this ist not the correct behaviour, because the disconnect will not be logged.

comment:6 by walter123, 11 years ago

Resolution: fixed
Status: closedreopened

comment:7 by gf, 11 years ago

Why are you reopening the ticket? The exit command is working.

Logging the disconnect event it is useless and totally unrelated to the reported issue?

Version 0, edited 11 years ago by gf (next)

in reply to:  7 comment:8 by walter123, 11 years ago

Replying to gf:

Why are you reopening the ticket? The exit command is working, right?

Logging the disconnect event is useless and totally unrelated to the reported issue?

I agree the exit command is working.
I thought, I should mentioned the original behaviour like in 1.1

If this is not correct, we can close this ticket.

Sorry for the trouble.

comment:9 by gf, 11 years ago

Resolution: fixed
Status: reopenedclosed

I think there is no need to log the disconnect events.

Note: See TracTickets for help on using tickets.