Opened 12 years ago

Closed 12 years ago

#2561 closed defect (fixed)

6853 not open /dev/sci

Reported by: ngc1927 Owned by: gf
Priority: critical Component: Card support
Severity: high Keywords:
Cc: gf@… Sensitive: no

Description

Revision

6853

Issue Description

Warnign when compiling and error with internal reader

When the issue occurs

During compilation and after start.
Attached file have compilation warning/info, and this is
error during start:

08:30:02        0 s check thread started
08:30:02        0 s creating thread for device /dev/sci0
08:30:02   618960 r stapi: STSMART-IFD: STSMART_Open 3
08:30:02   618960 r Cannot open device: /dev/sci0
08:30:02        0 s creating thread for device /dev/sci1
08:30:02   61A1A0 r stapi: STSMART-IFD: STSMART_Open 3
08:30:02   61A1A0 r Cannot open device: /dev/sci1

Attachments (4)

error.txt (4.4 KB ) - added by ngc1927 12 years ago.
test-patch.diff (4.9 KB ) - added by gf 12 years ago.
INTERNAL-reader-STAPI-fix.diff (3.2 KB ) - added by gf 12 years ago.
0001-csctapi-Checking-for-defined-WITH_STAPI-in-icc_async.patch (4.1 KB ) - added by gf 12 years ago.
Try this patch, please.

Download all attachments as: .zip

Change History (10)

by ngc1927, 12 years ago

Attachment: error.txt added

comment:1 by gf, 12 years ago

Cc: gf@… added

Could you try the attached test patch, save it in the oscam directory then run patch -p1 < test-patch.diff
then compile and test.

by gf, 12 years ago

Attachment: test-patch.diff added

comment:2 by gf, 12 years ago

If you compile without STAPI does it work?
Try with: make CROSS=/opt/STM/STLinux-2.3/devkit/sh4/bin/sh4-linux-

comment:3 by gf, 12 years ago

Ok, I think I see what is going on.
Before r6837 SCI_DEV was defined for the build with stapi. However since SCI_DEV have been checked before STAPI, the STAPI functions were never ever called when the reader was "internal". After my changes STAPI functions were called instead of SCI_DEV functions.

The fix should be to remove all STAPI code in icc_async.c (since it is wrong). The correct card reader type if you want to use STAPI is "stapi" but in your case the default internal reader is working.

Please test the attached patch (INTERNAL-reader-STAPI-fix.diff), it should allow your internal reader to work.

Last edited 12 years ago by gf (previous) (diff)

by gf, 12 years ago

Try this patch, please.

comment:4 by gf, 12 years ago

Even better try r6854. I have applied the fix because it looked obviously correct.

comment:5 by ngc1927, 12 years ago

I test now r6855 and work ok.
Thx gf for your fast and hard work.

comment:6 by ngc1927, 12 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.