bug in automatic reader restart

[BigGyros]

Revision

7149

Issue Description

reader restarts for saftey and after that only one user is able to get ecm's. second user needs to disconnect before he receives the right answers.

When the issue occurs

oscam recognizes wrong answer and restart reader. after this user2 in my log isn't able to receive a correct answer

How the issue is reproducable

see log

[Admin]

I think the problem is that your client reconnects exactly at the time when the reader is in disabled state (because the reader is restarting). I think the code part for this bug is basically untouched from mpcs times and this didn't know of reader restarts etc.
Please tell me:

• Is skyuk2 also an au user?
• Do you have any network readers or is oscam only configured with this local reader?
• Do you have user ident set?
• Can you try to add one line in module-newcamd.c so that

        if (add) filt.prids[filt.nprids++] = psfilt->prids[i];
      }
      return filt;
  

gets to

      if (add) filt.prids[filt.nprids++] = psfilt->prids[i];
    }
    memcpy(&filt, psfilt, sizeof(filt));
    return filt;

(this basically makes the whole code block above it inactive so we could remove it when we commit it but for testing it's ok)

[BigGyros]

first i will answer your questions.
-yes it is an au user
-oscam is only configured only with this card. other cards has their own instances
-no user ident is set

I will add this code and try my luck ;)

i have also get another error with this auto restart method where the reader doesn't really restarts. i will add it here.
if i try to kill this process it remains a defunct zombie and i am only able to run this instance again if i reboot the whole system.

[BigGyros]

i don't know why the reader isn't restarting now correct :/

2012/07/13 21:01:55  9F464A8 c skyuk2 (0963&000000/0000/158B/62:B6F1): found (82 ms) by skyuk 
2012/07/13 21:01:59  9F3D740 r skyuk [videoguard2] classD0 ins40: (-2) status not ok 12 eb
2012/07/13 21:01:59  9F3D740 r skyuk [videoguard2] The card is not answering correctly! Restarting reader for safety
2012/07/13 21:01:59  9F464A8 c skyuk2 (0963&000000/0000/1BBC/62:465F): not found (2450 ms) by skyuk 
2012/07/13 21:02:02  9F464A8 c skyuk2 (0963&000000/0000/232B/62:C738): rejected group (1 ms) (0/0/0/0) (no matching reader)
2012/07/13 21:02:38  9F464A8 c skyuk2 (0963&000000/0000/0EE9/6A:69A0): rejected group (1 ms) (0/0/0/0) (no matching reader)
2012/07/13 21:03:14  9F464A8 c skyuk2 (0963&000000/0000/232B/62:B478): rejected group (1 ms) (0/0/0/0) (no matching reader)
2012/07/13 21:03:34  9F464A8 c skyuk2 (0963&000000/0000/2582/77:8AEA): rejected group (1 ms) (0/0/0/0) (no matching reader)
2012/07/13 21:03:54  9F464A8 c skyuk2 (0963&000000/0000/1133/62:D686): rejected group (1 ms) (0/0/0/0) (no matching reader)
2012/07/13 21:04:09  9F464A8 c skyuk2 (0963&000000/0000/1133/62:52FB): rejected group (1 ms) (0/0/0/0) (no matching reader)

first log was with 7166 the last log was with 7168. i will test the patch with 7166 again. maybe 7167 brokes something?

[BigGyros]

great my issue with the restart was a reader problem. now the good part. it seems that the changed code has worked fine.

2012/07/15 13:43:44  94835B0 c skyuk2 (0963&000000/0000/1135/62:AACB): found (77 ms) by skyuk 
2012/07/15 13:43:44  94835B0 c skyuk2 (0963&000000/0000/0F2E/80:20BB): found (96 ms) by skyuk 
2012/07/15 13:43:47  947F010 r skyuk [videoguard2] classD0 ins40: (-2) status not ok ca 61
2012/07/15 13:43:47  947F010 r skyuk [videoguard2] The card is not answering correctly! Restarting reader for safety
2012/07/15 13:43:47  94835B0 c skyuk2 (0963&000000/0000/183D/62:5B25): not found (2450 ms) by skyuk 
2012/07/15 13:43:47  947F010 r skyuk [videoguard2] creating thread for device /dev/ttyUSB5
2012/07/15 13:43:50  9485868 r skyuk [videoguard2] Reader initialized (device=/dev/ttyUSB5, detect=cd, mhz=600, cardmhz=368)
2012/07/15 13:43:50  94835B0 c skyuk2 (0963&000000/0000/183B/62:A4B2): rejected group (1 ms) (0/0/0/0) (no matching reader)
2012/07/15 13:43:50  9485868 r skyuk [videoguard2] card detected
2012/07/15 13:43:55  9485868 r skyuk [mouse] ATR: 3F FD 13 25 02 50 00 0F 33 B0 0F 69 FF 4A 50 D0 00 00 53 59 02 
2012/07/15 13:43:56  9485868 r skyuk [mouse] Maximum frequency for this card is formally 5 Mhz, clocking it to 6.00 Mhz
2012/07/15 13:43:57  9485868 r skyuk [mouse] parental lock setting: 3F 00 0E 00 
2012/07/15 13:43:57  9485868 r skyuk [mouse] type: VideoGuard BSkyB (0963), caid: 0963
2012/07/15 13:43:57  9485868 r skyuk [mouse] serial: ########, BoxID: ########, baseyear: 1997
2012/07/15 13:43:57  9485868 r skyuk [mouse] ready for requests
2012/07/15 13:43:57  9485868 r skyuk [mouse] found cardsystem videoguard2
2012/07/15 13:43:57  9485868 r skyuk [videoguard2] card detected
2012/07/15 13:43:57  9485868 r skyuk [videoguard2] type: VideoGuard BSkyB (0963)
tiers...
2012/07/15 13:44:00  94835B0 c skyuk2 (0963&000000/0000/CCB5/62:425B): found (90 ms) by skyuk 
2012/07/15 13:44:00  94835B0 c skyuk2 (0963&000000/0000/0F2E/80:9EC0): found (103 ms) by skyuk 

[BigGyros]

patch from Admin is in this patchfile

[gf]

Is this patch still needed? If it is it should be applied and the ticket closed.

[BigGyros]

yes it's need i am still building with it and it's working. would be great if you can implement it. if i dont use this patch oscam won't work after auto reset on 0963 as on the first log.

[Deas]

r7813