Opened 12 years ago
Closed 12 years ago
#2662 closed defect (fixed)
MONITOR config should be a subset of the "WebIF" menu item, should be treated as the LCDSUPPORT is
Reported by: | Znuff | Owned by: | alno |
---|---|---|---|
Priority: | trivial | Component: | Webinterface |
Severity: | low | Keywords: | webif, monitor |
Cc: | Sensitive: | no |
Description
Revision
Issue Description
The CONFIGMONITOR.tpl includes the configuration for MONITOR, WEBIF and LCDSUPPORT.
LCDSUPPORT is loaded in the template by ##TPLLCDOPTIONS## and it has a conditional, which is fine.
Though you can't disable the MONITOR settings showing up, because the menu item is pretty much called MONITOR.
I suggest renaming the template item "WEBIF" (or something like that) and have conditionals for loading MONITOR and LCDSUPPORT (this one is already there). The logic behind is that you can compile a binary without MONITOR support, but this change wouldn't apply to a binary compiled without WEBIF support.
So, bottom line:
- Rename MONITOR to WEBIF.
- Hav WEBIF load MONITOR and LCDSUPPORT with conditionals
When the issue occurs
Compile binary without MONITOR support.
How the issue is reproducable
Compile binary without MONITOR support.
<log file not applicable>
Attachments (1)
Change History (6)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
Component: | Monitor-Interface → Webinterface |
---|
Retagging for WebIF component.
by , 12 years ago
Attachment: | hide_monitor.diff.txt added |
---|
Hide monitor parameters when oscam is build without monitor
comment:3 by , 12 years ago
This patch is from our good friend and fantastic coder gfto (Thanks)
This hides monitor parameters information when oscam is build without monitor.
Nothing relevant is changed.
Please submit to trunk.
Thanks
comment:5 by , 12 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Agree. I have opened a thread about it on forum
http://www.streamboard.tv/wbb2/thread.php?threadid=34672