Opened 11 years ago
Closed 11 years ago
#2859 closed enhancement (invalid)
Changeset [7705] by norbi20
Reported by: | norbi20 | Owned by: | norbi20 |
---|---|---|---|
Priority: | Please fill in | Component: | Protocol - CCCam |
Severity: | high | Keywords: | |
Cc: | Sensitive: | yes |
Description
CCcam ecm fix !
reader fix !
cliens fix !
Attachments (5)
Change History (19)
by , 11 years ago
Attachment: | module-cccam.c added |
---|
by , 11 years ago
Attachment: | oscam-reader.c added |
---|
by , 11 years ago
Attachment: | module-newcamd.c added |
---|
by , 11 years ago
Attachment: | module-dvbapi.c added |
---|
comment:1 by , 11 years ago
Owner: | set to |
---|---|
Priority: | major → Please fill in |
Status: | new → assigned |
Type: | task → enhancement |
comment:2 by , 11 years ago
Status: | assigned → new |
---|
comment:3 by , 11 years ago
comment:4 by , 11 years ago
copy in oscam-svn modified data files
The in terminal
make
make sh4
oscam easy build create oscam file
comment:5 by , 11 years ago
@norbi20:
Please create a patch for every fix, coz if there are new revisions out and people will test your changes the compilation goes wrong.
comment:6 by , 11 years ago
I was curious to examine his changes so I created the diff patch.
Seems he changed some timeouts to let it work in his oscam card system.
Perhaps we can use it as usefull input to make those timings userconfigable?
@Norbi: If you create tickets next time please try harder to make a description or write it in your native language and use google translate to get it into english and copy paste that! Your input can be useful but ignored due to bad language = bad improvements...
comment:7 by , 11 years ago
What fix? This just lowers all timeouts to 1/4 of their values. What that this fix?
comment:9 by , 11 years ago
Norbi, GF asks what this patch of your exactly fixes. Can you describe it to us?
comment:10 by , 11 years ago
@norbi20
i know how to build oscam - you don´t need to explain this to me...
but a PATCH makes it very easy to check what you changed. just click on the file theparasol created for you and you see excactly what was changed. the way you did it first is - sorry - useless.
comment:12 by , 11 years ago
Look I understand why you are lowering timeouts, the thing that is not clear is why the timeouts are set the way they are. What are you breaking by lowering the timeouts?
Also your patch is not only touching cccam, it changes the timeouts all over the place. Config items that are defined as seconds are changed to 250 ms which is certainly NOT ok. As for lowering sleep times, that can be discussed on case by case basis but a patch like the one posted above is just too wrong for the small gain it'll give you in certain cases.
comment:13 by , 11 years ago
comment:14 by , 11 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
as the cccam protocol is maintained by corsair in streamboard - please contact him and discuss this change with him. nobody will commit this without corsair says that it is ok.
please provide a PATCH and not full files.