Case sensitive ecm.info

[Bit]

I know, it's just cosmetics, but could it be possible to change the case-sensivity or the ecm.info?
I'd like the readers label to be case sensitive - same as in config file.
Ex: readers label in config is: "MyLivingRoom". Actual result in ecm.info: "mylivingroom".
That's not looking nice.
Thanks in advance.

[BurnMasterRecords]

You mean the Readerlabel ?

[Sky-DE] as an example?

That was an great Idea,

[Bit]

Exactly.

[MrWho]

i do agree

[gstw]

super

[CapNCooK]

i vouch for this too, but:

Every reader label is converted to lower case on save..
Therefore i don't understand how yours can be 'Sky-DE'.

The ecm.info reader content is just a reference to reader->label in code. So the question is actually: Is there a reason that readers are converted to lowercase in general ?

It's everywhere..

[Bit]

SAME(!) for log-entries. And reader labels in webinterface-table. Every label is converted to lowercase. :(

[ni hao]

+1 for display in WebIF but then also for Proxies and Clients !
It means that what is displayed in WebIF should be exactly the same as what the oscam-admin entered in the different (config) files.

[CapNCooK]

I think this might fix it..
First patch in my life, nice trycase ;-)

Moved parsing of label component to case-sensitive part of oscam-config-reader.c

This should make reader labels globally case-sensitive.

[CapNCooK]

disregard previous patch - use this one

[Bit]

Best suggestion was posted in the forum, after a long discussion:
Use the DESCRIPTION parameter (if set) in [reader] and [account] for log entries and ecm.info case sensitive!
I think this is a nice feature and permits to even 'hide' real-account names or real-readerlabels in the log. ;)

[hapeba]

This is a ticket system (Bit, the same is true for you ...) Please use forum for discuss.

[Bit]

This ticket should stay open until a dev closes it with real reasons and technical exanation.
The ticket system is also a 'todo list' where devs take a look from time to time.
This ticket is marked as minor wih low priority. So no hurry.

[devzero]

Readerlabel shown (and handled) case sensitive

[hapeba]

This is a ticket system, not a "todo list".
Please use forum and stop spam.

[devzero]

Added patch for case sensitive readerlabels. Please test. Pass -DREADERNAME_CASESENSITIVE=ON to cmake call to enable.
If you use Makefile in root, add this switch on your own.

Don't forget to edit your AU settings for a changed reader!

[hapeba]

This is not a patch-system.
Please use forum (this rule also true for you).

[BurnMasterRecords]

This Ticket stays open a working Solution is posted.

[hapeba]

Please stop the spam. It's no error.
Program and checkin to trunk.

[ni hao]

Nobody is writing about an error. Although it is not only ecm.info but also WebIF, so the subject is not quite well but who cares... This is a to-do-action and should be open. This is discussed at the forum with a good proposal from Admin, now a dev should pick it up from here and change the source(s).

[devzero]

I'll create a proper patch soon and will post it here for review and testing. Maybe I'll open a new ticket with right description and leave a link here.
My attached patch isn't working well at the moment - AU is not working (the textbox in webif stays empty). In the next version there will be an extra variable used as a "Shown label" (or so) so it's just cosmetic and the internal handling is done as before with lowercase values.

[devzero]

Sorry, no new filed - only an new internal variable.

[gf]

I'll convert reader config to the new parser tomorrow and this ticket would get fixed then.

[gf]

Fixed by r8175. Now the only limitation for reader names is that spaces are converted to underscores (_). Everything else is left as is.

[Bit]

I regret. in the case I label my reader "abc_ABC" and my dvbapi user has au=abc_ABC -> AU is OFF for dvbapi. Even though they are spelled EXACTLY the same. (before the reader parser changes, my reader was named like this and it worked.)
Only solution is: label the reader and the au= for the dvbapi user the SAME: in LOWERCASE ONLY. :(
Strange. Mixing upper/lowercase worked before, now it's broken?

[gf]

It worked before because the reader label's case was always lowered. Now it isn't. Anyway the full fix that allows reader labels to contain anything is commited in r8183.

[Bit]

Thanks gfto. Fixed with r8183.