#3043 closed enhancement (fixed)
Case sensitive ecm.info
Reported by: | Bit | Owned by: | theparasol |
---|---|---|---|
Priority: | trivial | Component: | DVBApi |
Severity: | low | Keywords: | ecm.info |
Cc: | Sensitive: | no |
Description
I know, it's just cosmetics, but could it be possible to change the case-sensivity or the ecm.info?
I'd like the readers label to be case sensitive - same as in config file.
Ex: readers label in config is: "MyLivingRoom". Actual result in ecm.info: "mylivingroom".
That's not looking nice.
Thanks in advance.
Attachments (3)
Change History (30)
comment:1 by , 10 years ago
comment:5 by , 10 years ago
i vouch for this too, but:
Every reader label is converted to lower case on save..
Therefore i don't understand how yours can be 'Sky-DE'.
The ecm.info reader content is just a reference to reader->label in code. So the question is actually: Is there a reason that readers are converted to lowercase in general ?
It's everywhere..
comment:6 by , 10 years ago
SAME(!) for log-entries. And reader labels in webinterface-table. Every label is converted to lowercase. :(
comment:7 by , 10 years ago
+1 for display in WebIF but then also for Proxies and Clients !
It means that what is displayed in WebIF should be exactly the same as what the oscam-admin entered in the different (config) files.
comment:8 by , 10 years ago
I think this might fix it..
First patch in my life, nice trycase ;-)
Moved parsing of label component to case-sensitive part of oscam-config-reader.c
This should make reader labels globally case-sensitive.
by , 10 years ago
Attachment: | reader_case_tryfix.patch.txt added |
---|
by , 10 years ago
Attachment: | reader_case_tryfix2_8073.patch added |
---|
disregard previous patch - use this one
comment:9 by , 10 years ago
Best suggestion was posted in the forum, after a long discussion:
Use the DESCRIPTION parameter (if set) in [reader] and [account] for log entries and ecm.info case sensitive!
I think this is a nice feature and permits to even 'hide' real-account names or real-readerlabels in the log. ;)
comment:10 by , 10 years ago
Resolution: | → invalid |
---|---|
Status: | new → closed |
This is a ticket system (Bit, the same is true for you ...) Please use forum for discuss.
comment:11 by , 10 years ago
Resolution: | invalid |
---|---|
Status: | closed → reopened |
This ticket should stay open until a dev closes it with real reasons and technical exanation.
The ticket system is also a 'todo list' where devs take a look from time to time.
This ticket is marked as minor wih low priority. So no hurry.
by , 10 years ago
Attachment: | oscam_reader_case_sensitive_rev1.patch added |
---|
Readerlabel shown (and handled) case sensitive
comment:12 by , 10 years ago
Resolution: | → invalid |
---|---|
Status: | reopened → closed |
This is a ticket system, not a "todo list".
Please use forum and stop spam.
comment:13 by , 10 years ago
Added patch for case sensitive readerlabels. Please test. Pass -DREADERNAME_CASESENSITIVE=ON to cmake call to enable.
If you use Makefile in root, add this switch on your own.
Don't forget to edit your AU settings for a changed reader!
comment:14 by , 10 years ago
Resolution: | invalid |
---|---|
Status: | closed → reopened |
comment:15 by , 10 years ago
Resolution: | → invalid |
---|---|
Status: | reopened → closed |
This is not a patch-system.
Please use forum (this rule also true for you).
comment:17 by , 10 years ago
Resolution: | invalid |
---|---|
Status: | closed → reopened |
comment:18 by , 10 years ago
Resolution: | → invalid |
---|---|
Status: | reopened → closed |
Please stop the spam. It's no error.
Program and checkin to trunk.
comment:19 by , 10 years ago
Resolution: | invalid |
---|---|
Status: | closed → reopened |
comment:20 by , 10 years ago
Nobody is writing about an error. Although it is not only ecm.info but also WebIF, so the subject is not quite well but who cares... This is a to-do-action and should be open. This is discussed at the forum with a good proposal from Admin, now a dev should pick it up from here and change the source(s).
comment:21 by , 10 years ago
I'll create a proper patch soon and will post it here for review and testing. Maybe I'll open a new ticket with right description and leave a link here.
My attached patch isn't working well at the moment - AU is not working (the textbox in webif stays empty). In the next version there will be an extra variable used as a "Shown label" (or so) so it's just cosmetic and the internal handling is done as before with lowercase values.
comment:23 by , 10 years ago
I'll convert reader config to the new parser tomorrow and this ticket would get fixed then.
comment:24 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Fixed by r8175. Now the only limitation for reader names is that spaces are converted to underscores (_). Everything else is left as is.
comment:25 by , 10 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I regret. in the case I label my reader "abc_ABC" and my dvbapi user has au=abc_ABC -> AU is OFF for dvbapi. Even though they are spelled EXACTLY the same. (before the reader parser changes, my reader was named like this and it worked.)
Only solution is: label the reader and the au= for the dvbapi user the SAME: in LOWERCASE ONLY. :(
Strange. Mixing upper/lowercase worked before, now it's broken?
comment:26 by , 10 years ago
It worked before because the reader label's case was always lowered. Now it isn't. Anyway the full fix that allows reader labels to contain anything is commited in r8183.
comment:27 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Thanks gfto. Fixed with r8183.
You mean the Readerlabel ?
[Sky-DE] as an example?
That was an great Idea,