Opened 11 years ago

Closed 11 years ago

#3382 closed defect (wontfix)

Allow "ratelimitecm" and "ratelimitseconds" for proxy reader in Webif reader section

Reported by: pr2 Owned by:
Priority: major Component: Webinterface
Severity: medium Keywords: ratelimitecm ratelimitseconds webif proxy
Cc: Sensitive: no

Description

Revision

1.20 svn 8755

Issue Description

There are 2 options that in the Webif we can only define on physical reader and not proxy reader:

http://www.streamboard.tv/wiki/OSCam/en/Config/oscam.server#ratelimitecm

http://www.streamboard.tv/wiki/OSCam/en/Config/oscam.server#ratelimitseconds

Those 2 options seems to work also on proxy reader (which is for some specific case very usefull to set), but since the Webif doesn't handle them properly, for proxy readers, the parameters disappeared each time we define them 'manually' in the oscam.server and then later we change any options in the webif that will generate a new oscam.server file.

Can you please fix it and allow "ratelimitecm" and "ratelimitseconds" for proxy readers in the webif too.

When the issue occurs

When you have a oscam.server with proxy reader with "ratelimitecm" and "ratelimitseconds" set and that you change any reader in the reader section of the Webif.

How the issue is reproducable

Define the parameter "ratelimitecm" and "ratelimitseconds" in the oscam.server for a proxy reader and go and change anything in the webif reader section.
Those parameters will disappeared from the oscam.server generated file if they were assigned to a proxy reader.

Change History (8)

comment:1 by Bit, 11 years ago

...if you ask ME... Setting ratelimiter on a proxy is nonsense.
But there are RARE circumstances where it could be helpful.
If ratelimiter would be integrated into the webinterface for proxys, there will be a lot of complaints by users why this doesn't work. (Because multiple oscams could be connected to this proxy. And in THIS case it's nonsense!)
My tip: don't use the webinterface's READER-page to change it's settings. Use it's FILE-page!

comment:2 by pr2, 11 years ago

Bit,

I disagree with your answer, if a paremeter can be set both on physical reader and on proxy reader it is not the Webif to decide or not if I can use for proxy reader.
Moreover it is stated nowhere in the wiki page (which I give links) that those parameters are restricted to local card reader.
People test "manually" the parameters of proxy reader and it is working fine for there specific need but parameter is lost when going in the webif: this is a bug.

Your tip is stupid: if there is a webif in OScam the aim is to use it!
Would you create a ticket to ask to suppress the OScam webif since we can configure everything manually in config files? I don't think so....
It is not because you don't need those parameters on a proxy reader that everybody should think like you.

Pr2

comment:3 by Deas, 11 years ago

just because a parameter CAN be set, it does not make sense to use it. and using ratelimiter on a proxy reader will not help to make oscam easier. ratelimiter is a complex feature only used for some specific cards. for me it also makes no sense to put it into the software reader section.

you should discuss this in the forum with the implementer of this feature. nobody else will touch this in the svn.

comment:4 by pr2, 11 years ago

This feature is working also on proxy for people that need it.
The parameter exist, the only think that I asked is to have it in the webif or at least that the webif doesn't discarded this parameter when used in the configuration file.

comment:5 by stefansat sat, 11 years ago

@pr2

Deas and Bit are wright, implementing the rate limiter in a proxy does not make sense att all. at least not for a proxy like cccam .

Perhaps in a camd proxy well as long as it is used for only one caid/provid.

This is however a job for the implementer off rate limit to set it in the wright sections.

That parameter should never had been possible for a cccam proxy.

Only for a local reader , and maybe handy for a camd reader ass well, but the only real reason why you should use camd with this feature at least is the case of and unreadable card for oscam where you will have to use another card reader/server for that card. I do not think that such is the case at the moment.

comment:6 by Bit, 11 years ago

That's the case stefansat.
There's a STB called Atlas which can read CSAT SECA HD (which has surflock) and TNTSAT HD, which can't be read by oscam.
And this STB shares only via radegast and has no ratelimiter built-in.
So, putting ratelimiter on this radegast proxy makes sense, BUT ONLY FOR THIS SPECIAL CASE.
And only if there's just ONE oscam connecting to this STB.
A really rare situation. But otherwise it's complete nonsense to use a ratelimiter on a proxy.
My opinion: use the configfiles to put the ratelimiter on the proxy and not the webinterface's reader setting page.

Last edited 11 years ago by Bit (previous) (diff)

comment:7 by stefansat sat, 11 years ago

@Bit

Well actually You can select the rate limiting by a proxy as long You do not use the web iff. But it does not work. It's enterely written for hw readers and based on the process_ecm function which is only there for local hw readers. has an interaction with cache and so on. No it wil just mess up all. Bring more troubles and bugs.

The majority of hw-reader settings can be set in the configs by any reader if you do not use the web iff. However if they do not concern a possible setting related to reader type proxy or hw_reader they just will do nothing. By just using the config in web iff you clean up the configs and remove unneeded and or useseles settings.

comment:8 by Bit, 11 years ago

Resolution: wontfix
Status: newclosed

After stefansat analysed the source, all is said. I'll close here.

Note: See TracTickets for help on using tickets.