"ECM Doublecheck" is broken - not working properly

[tunder8181]

Revision

r10130

Issue Description

"ECM Doublecheck" feature is not working properly. ECMs are being sent to both readers, but Oscam picks the fastest CW end sends it back to the client. Instead of first comparing the CW's and only after that return the CW to the client.

I have in my settings:
double_check = 1
lb_nbest_readers = 2

When the issue occurs

When one of the readers crashed, the other one continued to work normally and return CWs to the client. I would expect Oscam not to return any CWs since it cant compare them to the other reader.
I also tested the the other scenario. Two working readers. One with real card and second virtual reader with fake CW's.
ECMs were forwarded to both readers, but Oscam picked the fastest reader and sent back the CW to the client, without waiting for second CW to compare between them. I would expect Oscam in this case not to return any CW since they were different -one real and second one fake.
So in both cases, when one reader crashed and when one reader gave fake CWs, Oscam failed and continued providing CWs to the client.

How the issue is reproducable

Just do the same like me. Crash one of the readers or create another reader with different CWs.

[Aeon]

Please post a log.
It should contain some lines containing "DOUBLE CHECK".

[tunder8181]

When both readers are active, it shows "DOUBLE CHECK". But when one crashes, it continues to work normally and "DOUBLE CHECK" ends on one reader only.
I will try to reproduce and attach the log.

[Jannyy]

This bug is almost completely solved here: http://www.streamboard.tv/wbb2/thread.php?postid=576883

Thanks to Bust3D for bug fix and Optimum Power for patch file.

[Opti]

This bug is almost completely solved here: ​http://www.streamboard.tv/wbb2/thread.php?postid=576883