Opened 5 years ago

Closed 4 years ago

#4591 closed defect (fixed)

SSL Build Warnings unused functions

Reported by: Gorgone Impertinence Owned by:
Priority: minor Component: General
Severity: Please fill in Keywords:
Cc: Sensitive: no

Description

make USE_SSL=1
on debian 9

module-webif-lib.c:836:13: warning: ‘SSL_dyn_destroy_function’ defined but not used [-Wunused-function]
 static void SSL_dyn_destroy_function(struct CRYPTO_dynlock_value *l, const char *file, int32_t line)
             ^~~~~~~~~~~~~~~~~~~~~~~~
module-webif-lib.c:822:13: warning: ‘SSL_dyn_lock_function’ defined but not used [-Wunused-function]
 static void SSL_dyn_lock_function(int32_t mode, struct CRYPTO_dynlock_value *l, const char *file, int32_t line)
             ^~~~~~~~~~~~~~~~~~~~~
module-webif-lib.c:804:37: warning: ‘SSL_dyn_create_function’ defined but not used [-Wunused-function]
 static struct CRYPTO_dynlock_value *SSL_dyn_create_function(const char *file, int32_t line)
                                     ^~~~~~~~~~~~~~~~~~~~~~~
module-webif-lib.c:790:13: warning: ‘SSL_locking_function’ defined but not used [-Wunused-function]
 static void SSL_locking_function(int32_t mode, int32_t type, const char *file, int32_t line)
             ^~~~~~~~~~~~~~~~~~~~
module-webif-lib.c:785:22: warning: ‘SSL_id_function’ defined but not used [-Wunused-function]
 static unsigned long SSL_id_function(void)
                      ^~~~~~~~~~~~~~~
CC      module-webif.c

Attachments (1)

module-webif-lib.patch (1.5 KB ) - added by Gorgone Impertinence 5 years ago.

Download all attachments as: .zip

Change History (7)

by Gorgone Impertinence, 5 years ago

Attachment: module-webif-lib.patch added

comment:1 by Gorgone Impertinence, 5 years ago

please test sideeffects

comment:2 by AbrahaM, 5 years ago

test in progres, it seems that there is no side effects on webif using https,
test env.: mipsel-linux-gnu-ssl

comment:3 by The_Raven, 5 years ago

I ran in the same problem with raspi and the new raspian based on debian9.
This patch worked for me.

comment:4 by Gorgone Impertinence, 4 years ago

Resolution: fixed
Status: newclosed

comment:5 by Unique, 4 years ago

Resolution: fixed
Status: closedreopened
CC	oscam-simples.c
module-webif.c: In function ‘process_request’:
module-webif.c:6704:37: warning: ‘%02X’ directive output may be truncated writing between 2 and 8 bytes into a region of size 3 [-Wformat-truncation=]
     snprintf(buff, sizeof(buff), "0x%02X", len);
                                     ^~~~
module-webif.c:6704:34: note: directive argument in the range [0, 2147483647]
     snprintf(buff, sizeof(buff), "0x%02X", len);
                                  ^~~~~~~~
module-webif.c:6704:5: note: ‘snprintf’ output between 5 and 11 bytes into a destination of size 5
     snprintf(buff, sizeof(buff), "0x%02X", len);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CC	oscam-time.c
CC	oscam-work.c
CONF	build/x86_64-linux-gnu-ssl-libusb/config.c
BUILD	Distribution/list_smargo-1.20-unstable_svn11416-x86_64-linux-gnu-ssl-libusb
CC	oscam.c
LINK	/opt/s3/support/binaries/oscam-svn11416-debian-buster-webif-dvbapi-ssl-libusb.debug
STRIP	/opt/s3/support/binaries/oscam-svn11416-debian-buster-webif-dvbapi-ssl-libusb

Please fix

Last edited 4 years ago by Unique (previous) (diff)

comment:6 by Gorgone Impertinence, 4 years ago

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.