() of cpu type not correctly escaped in C_FLAGS

[vbin]

beon build_dir # cmake ..

-- Check for working C compiler: /usr/bin/gcc

-- Check for working C compiler: /usr/bin/gcc -- works

-- Check size of void*

-- Check size of void* - done

-- Looking for openssl/aes.h

-- Looking for openssl/aes.h - found

-- Check for working CXX compiler: /usr/bin/c++

-- Check for working CXX compiler: /usr/bin/c++ -- works

--

-- build type: unspecified

-- operating system: Linux

-- system type: Intel(R) Pentium(R) 4 CPU 1.70GHz-pc-linux

-- system: linux

-- cpu: Intel(R) Pentium(R) 4 CPU 1.70GHz

-- hw: pc

-- use system aes functions

--

-- Configuring done

-- Generating done

-- Build files have been written to: /usr/src/oscam-merlin/merlin/build_dir

beon build_dir # make

Scanning dependencies of target cscam

[ 1%] Building C object CMakeFiles/cscam.dir/src/CAM/cryptoworks.o

/bin/sh: -c: line 0: syntax error near unexpected token `('

/bin/sh: -c: line 0: `/usr/bin/gcc -I/usr/src/oscam-merlin/merlin/include -I/usr/src/oscam-merlin/merlin/csctapi -I/usr/src/oscam-merlin/merlin/cscrypt -DOS_LINUX -DCS_CONFDIR=\"/usr/local/etc\" -DCS_OSTYPE=\"Intel(R) Pentium(R) 4 CPU 1.70GHz-pc-linux\" -DCS_OS_CPU=\"Intel(R) Pentium(R) 4 CPU 1.70GHz\" -DCS_OS_HW=\"pc\" -DCS_OS_SYS=\"linux\" -DHAVE_AES -O3 -Winline -Werror -finline-functions -fomit-frame-pointer -o CMakeFiles/cscam.dir/src/CAM/cryptoworks.o -c /usr/src/oscam-merlin/merlin/src/CAM/cryptoworks.c'

make[2]: * [CMakeFiles/cscam.dir/src/CAM/cryptoworks.o] Error 2

make[1]: * [CMakeFiles/cscam.dir/all] Error 2

make: * [all] Error 2

[rorothetroll]

merlin branch abandoned. use trunk.

[vbin]

same problem with trunk

beon build_dir # cmake ..

--
-- operating system: Linux

-- system type: Intel(R) Pentium(R) 4 CPU 1.70GHz-pc-linux

-- system: linux

-- cpu: Intel(R) Pentium(R) 4 CPU 1.70GHz

-- hw: pc

-- use system aes functions

-- use system sha functions

--
-- Configuring done

-- Generating done

-- Build files have been written to: /usr/src/oscam-svn-r823/build_dir

beon build_dir # make

[ 1%] Building C object CMakeFiles/csmodules.dir/module-camd35.o

/bin/sh: -c: line 0: syntax error near unexpected token `('

/bin/sh: -c: line 0: `/usr/bin/gcc -I/usr/src/oscam-svn-r823/csctapi -I/usr/src/oscam-svn-r823/cscrypt -DOS_LINUX -DCS_CONFDIR=\"/usr/local/etc\" -DUSE_CMAKE -DCS_OSTYPE=\"Intel(R) Pentium(R) 4 CPU 1.70GHz-pc-linux\" -DCS_OS_CPU=\"Intel(R) Pentium(R) 4 CPU 1.70GHz\" -DCS_OS_HW=\"pc\" -DCS_OS_SYS=\"linux\" -DHAVE_AES -DHAVE_SHA -D'CS_SVN_VERSION="824"' -O3 -Winline -Wall -Wno-implicit-function-declaration -Wno-parentheses -finline-functions -fomit-frame-pointer -o CMakeFiles/csmodules.dir/module-camd35.o -c /usr/src/oscam-svn-r823/module-camd35.c'

make[2]: * [CMakeFiles/csmodules.dir/module-camd35.o] Error 2

make[1]: * [CMakeFiles/csmodules.dir/all] Error 2

make: * [all] Error 2

[rorothetroll]

When I do a cmake on all my linux box or OS X bix I get a system type that looks like that :
-- system type: x86_64-pc-linux
-- system type: i386-mac-macosx

.. so how do you get 'Intel(R) Pentium(R) 4 CPU 1.70GHz' for the cpu type ?!
as it's retrieved by cmake using :
set (CS_OS_CPU ${CMAKE_SYSTEM_PROCESSOR})

Are you overriding some system variables ?
what does arch returns on your box ?

[vbin]

diff -Nru oscam-svn/CMakeLists.txt oscam-svn-cpu/CMakeLists.txt

--- oscam-svn/CMakeLists.txt 2009-12-14 16:09:41.000000000 +0100

+++ oscam-svn-cpu/CMakeLists.txt 2009-12-14 22:28:49.000000000 +0100

@@ -117,8 +117,8 @@

set (CS_OSTYPE ${CS_OS_CPU}-${CS_OS_HW}-${CS_OS_SYS})

add_definitions ("-DUSE_CMAKE")

-add_definitions ("-DCS_OSTYPE=
\"${CS_OSTYPE}
\"")

-add_definitions ("-DCS_OS_CPU=
\"${CS_OS_CPU}
\"")

+add_definitions ("-D'CS_OSTYPE=\"${CS_OSTYPE}\"'")

+add_definitions ("-D'CS_OS_CPU=\"${CS_OS_CPU}\"'")

add_definitions ("-DCS_OS_HW=
\"${CS_OS_HW}
\"")

add_definitions ("-DCS_OS_SYS=
\"${CS_OS_SYS}
\"")

does the trick.

[100%] Built target oscam

beon build # arch

i686

I don't override variables, just cmake .. and make without options.

the cpu type could come from:

beon build # cat /proc/cpuinfo | grep name

model name : Intel(R) Pentium(R) 4 CPU 1.70GHz

beon build # cmake -h

cmake version 2.4-patch 6

building on a host with cmake 2.6-patch 4 works without my patch, probably a bug in cmake 2.4.

[alno]

no feedback - assume fixed